Bug 303079
| Summary: | Remove use of CompactPtr for Structure::m_classInfo. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
ClassInfo is located in CONST_DATA, and it is not guaranteed that CONST_DATA will be located in the same 36-bit address range that applies to heap allocated memory.
Also, sizeof(Structure) on iOS (and peers) is 104. With the removal of this CompactPtr, sizeof(Structure) increases to 112. However, on iOS, Structures require 32 atom (alignment), which takes its size class up to 128. This means the size increase will be completely inconsequential.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/165381788>
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/54434
EWS
Committed 303621@main (150dba5b9324): <https://commits.webkit.org/303621@main>
Reviewed commits have been landed. Closing PR #54434 and removing active labels.