Bug 303065
| Summary: | [RenderStyleGen] Add initial support generating parts of RenderStyle | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | CSS | Assignee: | Sam Weinig <sam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 18 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Weinig
Add initial support generating parts of RenderStyle, including the generation of a few test properties.
This will be done in stages:
Stage 1: Add initial support in the generator for getter and setter function implementations and enable it for a few properties. Function declarations remain hand written.
Stage 2: Enable for remaining non-special cased property getter and setter function implementations. Function declarations remain hand written.
Stage 3: Generate the function declarations for the already generated getter and setter function implementations.
Stage 4: Generate initial value functions.
Stage 5: Remove as many special cases as practical.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
I didn't mention it above, but the point of leaving the function declarations hand written initially is that we use them to ensure the implementations have the correct signatures, validating the work.
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/54423
EWS
Committed 303544@main (122ea46408f0): <https://commits.webkit.org/303544@main>
Reviewed commits have been landed. Closing PR #54423 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/165403506>