Bug 303017
| Summary: | AudioVideoRenderer::requestMediaDataWhenReady should return a NativePromise | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=303001 | ||
Jean-Yves Avenard [:jya]
In bug 303001 re-entrancy in the callback was exposed as an issue that could easily cause problems.
We also now only going to call the callback once.
To make the code safer, we should be using NativePromises instead.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/165288972>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/54387
EWS
Committed 303486@main (53acf55d821f): <https://commits.webkit.org/303486@main>
Reviewed commits have been landed. Closing PR #54387 and removing active labels.