Bug 303011 – REGRESSION(302346@main): [GTK] ScrollbarThemeGtk.h:48:220: error: non-virtual member function marked 'override' hides virtual member function

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Michael Catanzaro]

Build error with cairo enabled

/builddir/build/BUILD/webkitgtk-2.51.2-build/webkitgtk-2.51.2/Source/WebCore/platform/gtk/ScrollbarThemeGtk.h:48:220: error: non-virtual member function marked 'override' hides virtual member function
   48 |     int scrollbarThickness(ScrollbarWidth = ScrollbarWidth::Auto, ScrollbarExpansionState = ScrollbarExpansionState::Expanded, OverlayScrollbarSizeRelevancy = OverlayScrollbarSizeRelevancy::IncludeOverlayScrollbarSize) override;
      |                                                                                                                                                                                                                            ^
/builddir/build/BUILD/webkitgtk-2.51.2-build/webkitgtk-2.51.2/Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.h:49:9: note: hidden overloaded virtual function 'WebCore::ScrollbarThemeAdwaita::scrollbarThickness' declared here: different number of parameters (2 vs 3)
   49 |     int scrollbarThickness(ScrollbarWidth, OverlayScrollbarSizeRelevancy = OverlayScrollbarSizeRelevancy::IncludeOverlayScrollbarSize) override;
      |         ^
In file included from /builddir/build/BUILD/webkitgtk-2.51.2-build/webkitgtk-2.51.2/webkit2gtk-4.1/redhat-linux-build/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-68.cpp:3:
/builddir/build/BUILD/webkitgtk-2.51.2-build/webkitgtk-2.51.2/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:515:90: error: too many arguments to function call, expected at most 2, have 3
  515 |         return ScrollbarThemeAdwaita::scrollbarThickness(scrollbarWidth, expansionState, overlayRelevancy);
      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                 ^~~~~~~~~~~~~~~~
/builddir/build/BUILD/webkitgtk-2.51.2-build/webkitgtk-2.51.2/Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.h:49:9: note: 'scrollbarThickness' declared here
   49 |     int scrollbarThickness(ScrollbarWidth, OverlayScrollbarSizeRelevancy = OverlayScrollbarSizeRelevancy::IncludeOverlayScrollbarSize) override;
      |         ^                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.

[Michael Catanzaro]

Pull request: https://github.com/WebKit/WebKit/pull/54422

[EWS]

Committed 303538@main (6800cae66f66): <https://commits.webkit.org/303538@main>

Reviewed commits have been landed. Closing PR #54422 and removing active labels.