Bug 303006

Summary:

[blocks-in-inline] Add support for block after side of margin handling (part 2)

Product:

WebKit

Reporter:

alan <zalan>

Component:

New Bugs

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

koivisto, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

303054

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
[fast-cq]Patch	none

alan

Reported 2025-11-22 06:21:10 PST

ssia

Attachments
Patch (15.66 KB, patch) 2025-11-22 06:30 PST, alan	no flags	Details Formatted Diff Diff
Patch (18.92 KB, patch) 2025-11-23 06:54 PST, alan	no flags	Details Formatted Diff Diff
Patch (18.92 KB, patch) 2025-11-23 08:26 PST, alan	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (15.52 KB, patch) 2025-11-23 19:26 PST, alan	no flags	Details Formatted Diff Diff
Patch (8.73 KB, patch) 2025-11-24 09:17 PST, alan	no flags	Details Formatted Diff Diff
Patch (9.69 KB, patch) 2025-11-24 09:26 PST, alan	no flags	Details Formatted Diff Diff
[fast-cq]Patch (9.69 KB, patch) 2025-11-24 11:46 PST, alan	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2025-11-22 06:30:43 PST

Created attachment 477475 [details] Patch

Antti Koivisto

Comment 2 2025-11-22 07:10:00 PST

Comment on attachment 477475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=477475&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:1033 > + auto marginInfo = MarginInfo { *this, MarginInfo::IgnoreScrollbarForAfterMargin::No }; > + layoutInlineContent(marginInfo, relayoutChildren, repaintLogicalTop, repaintLogicalBottom); > + handleAfterSideOfBlock(marginInfo); nice!

alan

Comment 3 2025-11-23 06:54:42 PST

Created attachment 477485 [details] Patch

alan

Comment 4 2025-11-23 08:26:11 PST

Created attachment 477486 [details] Patch

alan

Comment 5 2025-11-23 19:26:49 PST

Created attachment 477490 [details] Patch

alan

Comment 6 2025-11-24 09:17:55 PST

Created attachment 477497 [details] Patch