| Summary: | Inconsistent handling of gettext domain can cause compile failure | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Macks <dmacks> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.6 | ||||||
| URL: | http://permalink.gmane.org/gmane.os.apple.fink.general/28859 | ||||||
| Attachments: |
|
||||||
Created attachment 41181 [details]
Use DOMAIN variable instead of hard-coded value
Comment on attachment 41181 [details]
Use DOMAIN variable instead of hard-coded value
ok.
Comment on attachment 41181 [details] Use DOMAIN variable instead of hard-coded value Clearing flags on attachment: 41181 Committed r49773: <http://trac.webkit.org/changeset/49773> All reviewed patches have been landed. Closing bug. |
Several makefiles hardcode the gettext domain in the .pot filename ("webkit.pot") but other parts of the makefiles (and the code that accesses them) use a variable. The following is using webkit-1.1.10 release, but the code that triggers the problem appears the same in svn trunk. All support pkgs supplied via fink at the level of GNOME2.26, and gettext 0.14.5: 1. Edit configure -GETTEXT_PACKAGE=$PACKAGE +GETTEXT_PACKAGE="${PACKAGE}-1.0.2" 2. Build the package ./configure --prefix=/sw --disable-dependency-tracking \ --enable-gtk-doc \ --disable-video \ --disable-jit \ PKG_CONFIG_PATH="/sw/lib/fontconfig2/lib/pkgconfig:$PKG_CONFIG_PATH" \ XT_CFLAGS=" " XT_LIBS=-lXt mkdir DerivedSources make make -C WebKit/gtk/docs Build failure (reported by several users on multiple OSX versions): /sw/bin/msgmerge --update de.po webkit-1.0.2.pot /sw/bin/msgmerge: error while opening "webkit-1.0.2.pot" for reading: No such file or directory make[1]: *** [WebKit/gtk/po/de.po] Error 1 make: *** [all] Error 2 The bug is that the make recipe for the "webkit-1.0.2.pot" target generates "webkit.pot": /sw/bin/xgettext --default-domain=webkit-1.0.2 --directory=. \ --add-comments=TRANSLATORS: \ --files-from=./WebKit/gtk/po/POTFILES \ --copyright-holder='' \ --msgid-bugs-address="$msgid_bugs_address" \ --keyword=_ --keyword=N_ -o ./WebKit/gtk/po/webkit.pot The -o flag is hardcoded instead of using the $DOMAIN variable.