Bug 302887 – REGRESSION(303218@main)[macOS] ASSERTION FAILED: it != samplerStates.end() /Volumes/Data/worker/macOS-Tahoe-Debug-Build-EWS/build/Source/WebGPU/WebGPU/Sampler.mm

• Component: WebGPU
• Status: RESOLVED FIXED

[Marta Darbinyan]

Two tests are crashing in macOS after 303218@main.

http/tests/webgpu/webgpu/api/operation/sampling/filter_mode.html
http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/texture_utils.html

stderr:
ASSERTION FAILED: it != samplerStates.end()
/Volumes/Data/worker/macOS-Tahoe-Debug-Build-EWS/build/Source/WebGPU/WebGPU/Sampler.mm(270) : void WebGPU::uncacheSamplerState(const Sampler::UniqueSamplerIdentifier &, __strong id<MTLSamplerState>)
1   0x109b5cd68 WebGPU::uncacheSamplerState(std::__1::array<unsigned int, 4ul> const&, id<MTLSamplerState>)
2   0x109b5cbec WebGPU::Sampler::~Sampler()
3   0x109b5d02c WebGPU::Sampler::~Sampler()
4   0x1099a6f9c WTF::RefCounted<WebGPU::Sampler>::deref() const
5   0x1099a6f28 WTF::DefaultRefDerefTraits<WebGPU::Sampler>::derefIfNotNull(WebGPU::Sampler*)
6   0x1099aef38 WTF::RefPtr<WebGPU::Sampler, WTF::RawPtrTraits<WebGPU::Sampler>, WTF::DefaultRefDerefTraits<WebGPU::Sampler>>::~RefPtr()
7   0x10998fe04 WTF::RefPtr<WebGPU::Sampler, WTF::RawPtrTraits<WebGPU::Sampler>, WTF::DefaultRefDerefTraits<WebGPU::Sampler>>::~RefPtr()
8   0x1099a3dfc WTF::KeyValuePair<WTF::RefPtr<WebGPU::Sampler, WTF::RawPtrTraits<WebGPU::Sampler>, WTF::DefaultRefDerefTraits<WebGPU::Sampler>>, WTF::EnumeratedArray<WebGPU::ShaderStage, std::__1::optional<unsigned int>, (WebGPU::ShaderStage)2>>::~KeyValuePair()

Test history:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Fwebgpu%2Fwebgpu%2Fapi%2Foperation%2Fsampling%2Ffilter_mode.html&test=http%2Ftests%2Fwebgpu%2Fwebgpu%2Fshader%2Fexecution%2Fexpression%2Fcall%2Fbuiltin%2Ftexture_utils.html

Test results:
https://ews-build.webkit.org/#/builders/161/builds/3686

[Radar WebKit Bug Importer]

<rdar://problem/165151514>

[EWS]

Test gardening commit 303370@main (d0c732e0b6f0): <https://commits.webkit.org/303370@main>

Reviewed commits have been landed. Closing PR #54290 and removing active labels.

[Mike Wyrzykowski]

https://commits.webkit.org/303393@main undid the test gardening as the regression was fixed, I think this can be resolved now