Bug 302852
| Summary: | [GTK] Broken build when libwebrtc is enabled | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Cristina Murillo <cmurillo> |
| Component: | Platform | Assignee: | Cristina Murillo <cmurillo> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Cristina Murillo
If libWebRTC is enabled by passing -DUSE_GSTREAMER_WEBRTC=OFF in the cmakeargs, RealtimeOutgoingAudioSourceLibWebRTC fails to compile with the following error:
RealtimeOutgoingAudioSourceLibWebRTC.h:55:38: error: unknown type name 'MediaTime'; did you mean 'WTF::MediaTime'?
55 | void audioSamplesAvailable(const MediaTime&, const PlatformAudioData&, const AudioStreamDescription&, size_t) final;
The compilation fails due to a missing MediaTime.h include (used by audioSamplesAvailable parameter).
Additionally, there are incorrect platform guards, the gstreamer specific implementation is currently guarded only by USE(LIBWEBRTC),
potentially causing build failures on platforms with libWebRTC but without GStreamer.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Cristina Murillo
Pull request: https://github.com/WebKit/WebKit/pull/54241
EWS
Committed 303322@main (547a9d491095): <https://commits.webkit.org/303322@main>
Reviewed commits have been landed. Closing PR #54241 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/165123607>