Bug 302668
| Summary: | [Style] LineWidth evaluation performs redundant LayoutUnit conversion in floorToDevicePixel | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Taher <taher_ali> |
| Component: | CSS | Assignee: | Taher <taher_ali> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Taher
When evaluating border widths during layout, Evaluation<Result>::operator() calls floorToDevicePixel(float, float) which internally converts the float to LayoutUnit, performs the snapping calculation, and returns a float. This result is then converted to LayoutUnit (if Result is LayoutUnit) again by the caller.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/164917570>
Taher
Pull request: https://github.com/WebKit/WebKit/pull/54074
EWS
Committed 303290@main (0f6e74d7d5d2): <https://commits.webkit.org/303290@main>
Reviewed commits have been landed. Closing PR #54074 and removing active labels.