Bug 302585
| Summary: | CMSampleBuffer serialiser doesn't handle when kCMFormatDescriptionExtension_SampleDescriptionExtensionAtoms contains more than one key | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jean-Yves Avenard [:jya]
When serialising a CMSampleBuffer to be transferred over IPC we first convert it to a MediaSampleBlock and its TrackInfo.
The file loaded by the test `LayoutTests/media/media-source/media-managedmse-webvtt-track.html ` causes a decoding error when MediaSourceUseRemoteAudioVideoRenderer is enabled.
The reason is that the file content/bip-bop-webvtt-frag.mp4's `avc1` box contains two keys: that standard `avcC` and a `btrt` one.
The code to convert the CMFormatDescriptionRef to a VideoInfo createVideoInfoFromFormatDescription assumes that the required data to decode the video when two keys are present is the first one. But that's not always the case.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/164817308>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/54000
EWS
Committed 303154@main (05d2e2c1d540): <https://commits.webkit.org/303154@main>
Reviewed commits have been landed. Closing PR #54000 and removing active labels.