Bug 302485
| Summary: | [webkitpy] Executive.run_command should log command before running. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Schwartz <ben_schwartz> |
| Component: | Tools / Tests | Assignee: | Ben Schwartz <ben_schwartz> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ben Schwartz
Executive.run_command only logs the command being run after it completes. For debugging purposes, it would be great to have logging before the command is run so that we can see which commands are hanging. To supplement this change, we should only log at the end if it takes longer than x seconds (where x is whatever we deem is the end of a reasonable timeframe) or if the exit code wasn't 0.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/164649390>
Ben Schwartz
Pull request: https://github.com/WebKit/WebKit/pull/53887
EWS
Committed 303002@main (0e7432d919ef): <https://commits.webkit.org/303002@main>
Reviewed commits have been landed. Closing PR #53887 and removing active labels.