Bug 302329
| Summary: | Use correct format specifiers in UIGamepadProvider logging | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Platform | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Adrian Perez
In file included from /home/aperez/wpe/cerbero/build/sources/android_arm64/wpewebkit-2.50.0/b/DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-27.cpp:4:
/home/aperez/devel/WebKit-Android/Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp:135:110: warning: format specifies type 'size_t' (aka 'unsigned long') but the argument has type 'unsigned int' [-Wformat]
135 | RELEASE_LOG_ERROR(Gamepad, "Unknown platform gamepad disconnect: Index %zu with %zu known gamepads", gamepad.index(), m_gamepads.size());
| ~~~ ^~~~~~~~~~~~~~~
| %u
/home/aperez/wpe/cerbero/build/sources/android_arm64/wpewebkit-2.50.0/b/WTF/Headers/wtf/Assertions.h:732:74: note: expanded from macro 'RELEASE_LOG_ERROR'
732 | #define RELEASE_LOG_ERROR(channel, ...) LOG_ANDROID_SEND(channel, ERROR, __VA_ARGS__)
| ^~~~~~~~~~~
/home/aperez/wpe/cerbero/build/sources/android_arm64/wpewebkit-2.50.0/b/WTF/Headers/wtf/Assertions.h:728:117: note: expanded from macro 'LOG_ANDROID_SEND'
728 | __android_log_print(ANDROID_LOG_ ## priority, LOG_CHANNEL_WEBKIT_SUBSYSTEM, "[%s] " fmt, logChannel.name, ##__VA_ARGS__); \
| ~~~ ^~~~~~~~~~~
1 warning generated.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/53742
EWS
Committed 302869@main (0a6a3aa627d3): <https://commits.webkit.org/302869@main>
Reviewed commits have been landed. Closing PR #53742 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/164511497>