Bug 302302
| Summary: | Have MediaPlayerPrivateInterface::defaultSpatialTrackingLabel and spatialTrackingLabel return a String | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jean-Yves Avenard [:jya]
They currently return a `const String&`
Returning a reference prevents the ability to use WTF_GUARDED_BY_CAPABILITY and there's no advantage in returning a const String& as it's just a wrapper around a RefPtr<StringImpl>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/164443770>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/53727
EWS
Committed 302873@main (2d6710445112): <https://commits.webkit.org/302873@main>
Reviewed commits have been landed. Closing PR #53727 and removing active labels.