Bug 302069
| Summary: | _ willStartRenderingUpdateDisplay crashes when _private->page is null | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | jlee53 |
| Component: | New Bugs | Assignee: | Robert Jenner <jenner> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
jlee53
In the function WebView::_willStartRenderingUpdateDisplay (in WebkitLegacy), the page can become null between when it is originally null-checked if (_private->page) and when willStartRenderingUpdateDisplay starts executing. This is due to an increased delay from WebThreadLock();
We should move WebThreadLock() before page->willStartRenderingUpdateDisplay starts executing so that the page cannot be manipulated by the WebThread before page->willStartRenderingUpdateDisplay runs.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
jlee53
<rdar://problem/164022564>
jlee53
Pull request: https://github.com/apple/WebKit/pull/3986
Robert Jenner
<rdar://problem/166335789>
Robert Jenner
Pull request: https://github.com/WebKit/WebKit/pull/55454
EWS
Committed 304517@main (41c6f81fa853): <https://commits.webkit.org/304517@main>
Reviewed commits have been landed. Closing PR #55454 and removing active labels.