Bug 30200

Summary: Move executeScript from FrameLoader to ScriptController
Product: WebKit Reporter: Adam Barth <abarth>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 29947    
Attachments:
Description Flags
Patch v1
none
Patch v1
none
Patch v1 eric: review+, commit-queue: commit-queue-

Adam Barth
Reported 2009-10-08 01:04:33 PDT
executeScript and executeIfJavaScriptURL are really about controlling scripts, not about loading pages. Therefore, we should move them from FrameLoader to ScriptController!
Attachments
Patch v1 (25.36 KB, patch)
2009-10-08 01:14 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch v1 (25.91 KB, patch)
2009-10-08 01:16 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch v1 (30.98 KB, patch)
2009-10-08 10:26 PDT, Adam Barth 		eric: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-10-08 01:14:33 PDT
Created attachment 40856 [details] Patch v1
Adam Barth
Comment 2 2009-10-08 01:16:10 PDT
Created attachment 40857 [details] Patch v1
Eric Seidel (no email)
Comment 3 2009-10-08 09:32:29 PDT
Comment on attachment 40857 [details] Patch v1 Can you first invent a x-platform ScriptController if your'e going to add duplicate code? ScriptController And then ScriptControllerJSC and ScriptControllerV8 which inherit from it? Or heck, you don't even need them to inherit. Just add a new ScriptController.cpp at the root level which has these fixes, and makes sure both builds include it, no? Unless this code is not copy/paste and I'm mising something? r- for adding copy/paste code.
Adam Barth
Comment 4 2009-10-08 10:26:06 PDT
Created attachment 40890 [details] Patch v1
Eric Seidel (no email)
Comment 5 2009-10-08 19:13:25 PDT
Comment on attachment 40890 [details] Patch v1 ChangeLog is out of date. ScriptControllerBase being a real class would be better, but this is OK.
WebKit Commit Bot
Comment 6 2009-10-08 21:47:44 PDT
Comment on attachment 40890 [details] Patch v1 Rejecting patch 40890 from commit-queue. Patch https://bugs.webkit.org/attachment.cgi?id=40890 from bug 30200 failed to download and apply.
Adam Barth
Comment 7 2009-10-08 22:09:03 PDT
Committed r49372: <http://trac.webkit.org/changeset/49372>
Eric Seidel (no email)
Comment 8 2009-10-09 14:33:30 PDT
XCode project simply went out of date.
Note You need to log in before you can comment on or make changes to this bug.