Bug 30198

Summary: Gtk fails media/video-source-error.html (due to trailing whitespace?)
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch
eric: review-
Patch none

Philippe Normand
Reported 2009-10-08 00:34:20 PDT
One single space can break a test? ;)
Attachments
proposed patch (1.56 KB, patch)
2009-10-08 01:36 PDT, Philippe Normand 		eric: review-
DetailsFormatted DiffDiff
Patch (1.29 KB, patch)
2012-04-03 04:52 PDT, Simon Pena 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2009-10-08 01:36:03 PDT
Created attachment 40859 [details] proposed patch
Darin Adler
Comment 2 2009-10-08 07:24:34 PDT
Comment on attachment 40859 [details] proposed patch If this change is needed, why isn't the test failing on the buildbot?
Philippe Normand
Comment 3 2009-10-08 07:46:27 PDT
Well yeah please ignore this patch, obviously we do something wrong in the GTK+ port so changing the expected result is not the good approach
Eric Seidel (no email)
Comment 4 2009-10-08 09:29:47 PDT
Comment on attachment 40859 [details] proposed patch Per above comments from author.
Philippe Normand
Comment 5 2009-10-08 09:43:02 PDT
I asked to ignore the patch, not the bug. :)
Eric Seidel (no email)
Comment 6 2009-10-08 09:46:39 PDT
Seems like the bug needs a new title then. :)
Simon Pena
Comment 7 2012-04-03 04:52:37 PDT
Created attachment 135310 [details] Patch
Philippe Normand
Comment 8 2012-04-03 05:28:50 PDT
Comment on attachment 135310 [details] Patch Ok let's try :)
WebKit Review Bot
Comment 9 2012-04-03 06:07:11 PDT
Comment on attachment 135310 [details] Patch Clearing flags on attachment: 135310 Committed r113020: <http://trac.webkit.org/changeset/113020>
WebKit Review Bot
Comment 10 2012-04-03 06:07:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.