Bug 30198

Summary: Gtk fails media/video-source-error.html (due to trailing whitespace?)
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch
eric: review-
Patch none

Description Philippe Normand 2009-10-08 00:34:20 PDT 
One single space can break a test? ;)
Comment 1 Philippe Normand 2009-10-08 01:36:03 PDT 
Created attachment 40859 [details]
proposed patch
Comment 2 Darin Adler 2009-10-08 07:24:34 PDT 
Comment on attachment 40859 [details]
proposed patch

If this change is needed, why isn't the test failing on the buildbot?
Comment 3 Philippe Normand 2009-10-08 07:46:27 PDT 
Well yeah please ignore this patch, obviously we do something wrong in the GTK+ port so changing the expected result is not the good approach
Comment 4 Eric Seidel (no email) 2009-10-08 09:29:47 PDT 
Comment on attachment 40859 [details]
proposed patch

Per above comments from author.
Comment 5 Philippe Normand 2009-10-08 09:43:02 PDT 
I asked to ignore the patch, not the bug. :)
Comment 6 Eric Seidel (no email) 2009-10-08 09:46:39 PDT 
Seems like the bug needs a new title then. :)
Comment 7 Simon Pena 2012-04-03 04:52:37 PDT 
Created attachment 135310 [details]
Patch
Comment 8 Philippe Normand 2012-04-03 05:28:50 PDT 
Comment on attachment 135310 [details]
Patch

Ok let's try :)
Comment 9 WebKit Review Bot 2012-04-03 06:07:11 PDT 
Comment on attachment 135310 [details]
Patch

Clearing flags on attachment: 135310

Committed r113020: <http://trac.webkit.org/changeset/113020>
Comment 10 WebKit Review Bot 2012-04-03 06:07:16 PDT 
All reviewed patches have been landed.  Closing bug.