Bug 301924
| Summary: | [masonry] Crash with 0 elements | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brandon <brandonstewart> |
| Component: | New Bugs | Assignee: | Brandon <brandonstewart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brandon
When a masonry container has 0 elements it is causing a crash, because we are asserting during item placement that we have tracks. This isn't accurate, because we have no elements.
Since the test cases swapped over to using display: masonry this is the test case I used to verify the fix.
<!DOCTYPE html>
<html>
<style>
.empty-container {
display: grid;
grid-template-rows: masonry; and grid-template-columns: masonry;
}
</style>
<body>
<p>Test that an empty masonry container renders nothing.</p>
<div class="empty-container"></div>
</body>
</html>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/164003234>
Brandon
Pull request: https://github.com/WebKit/WebKit/pull/53389
EWS
Committed 302541@main (92dc5fc313bd): <https://commits.webkit.org/302541@main>
Reviewed commits have been landed. Closing PR #53389 and removing active labels.