Bug 301873

Summary:

REGRESSION (300911@main): Card layout on archidekt.com is incorrect

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, sam, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=299972

Attachments:

Description	Flags
Screenshot	none
Reduced test case	none
Screenshot of reduction (shipping)	none
Screenshot of reduction (ToT)	none
Reduced test case	none
Reduced test case	none

Simon Fraser (smfr)

Reported 2025-11-03 11:09:59 PST

Created attachment 477265 [details] Screenshot Load https://archidekt.com/decks/17173061/calamity_galloping_inferno and note how the cards don't stack correctly like they do in older builds, or on other browsers. <rdar://163605539>

Attachments
Screenshot (9.98 MB, image/png) 2025-11-03 11:09 PST, Simon Fraser (smfr)	no flags	Details
Reduced test case (1.03 KB, text/html) 2025-11-05 12:40 PST, Sam Weinig	no flags	Details
Screenshot of reduction (shipping) (525.37 KB, image/png) 2025-11-05 12:43 PST, Sam Weinig	no flags	Details
Screenshot of reduction (ToT) (507.27 KB, image/png) 2025-11-05 12:43 PST, Sam Weinig	no flags	Details
Reduced test case (772 bytes, text/html) 2025-11-05 12:50 PST, Sam Weinig	no flags	Details
Reduced test case (686 bytes, text/html) 2025-11-05 12:53 PST, Sam Weinig	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2025-11-03 11:17:51 PST

Looks like it's about: .imageStack_cardStack__IFA_m > div:not(:first-child) { margin-top: calc(-125% - 25px); }

Sam Weinig

Comment 2 2025-11-05 12:40:40 PST

Created attachment 477310 [details] Reduced test case

Sam Weinig

Comment 3 2025-11-05 12:43:13 PST

Created attachment 477311 [details] Screenshot of reduction (shipping)

Sam Weinig

Comment 4 2025-11-05 12:43:31 PST

Created attachment 477312 [details] Screenshot of reduction (ToT)

Sam Weinig

Comment 5 2025-11-05 12:50:57 PST

Created attachment 477314 [details] Reduced test case

Sam Weinig

Comment 6 2025-11-05 12:53:04 PST

Created attachment 477315 [details] Reduced test case

Sam Weinig

Comment 7 2025-11-05 12:58:07 PST

Looking like an issue with the interaction of grid and margins. Probably the change to gridItemHasMargin in GridLayoutFunctions.cpp, but I need to verify that.

Sam Weinig

Comment 8 2025-11-05 13:07:48 PST

Pull request: https://github.com/WebKit/WebKit/pull/53478

EWS

Comment 9 2025-11-07 13:19:59 PST

Committed 302744@main (44b22eb1df10): <https://commits.webkit.org/302744@main> Reviewed commits have been landed. Closing PR #53478 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.