Bug 30178 – Make the setMetadataURL function foolproof by having it remove user info

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Darin Adler]

Callers should not pass URLs with user info to setMetadataURL, but if they do, that function should remove it.

[Darin Adler]

Created attachment 40810 [details]
patch

[Darin Adler]

<rdar://problem/6544670>

[John Sullivan]

Comment on attachment 40810 [details]
patch

> Index: WebKit/mac/Misc/WebNSURLExtras.mm
> ===================================================================
> --- WebKit/mac/Misc/WebNSURLExtras.mm	(revision 49253)
> +++ WebKit/mac/Misc/WebNSURLExtras.mm	(working copy)
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (C) 2005, 2007, 2008 Apple Inc. All rights reserved.
> + * Copyright (C) 2005, 2007, 2008, 2009 Apple Inc. All rights reserved.
>   * Copyright (C) 2006 Alexey Proskuryakov ([e-mail])
>   *
>   * Redistribution and use in source and binary forms, with or without
> @@ -619,17 +619,6 @@ static CFStringRef createStringWithEscap
>      return result;
>  }
>  
> -typedef struct {
> -    NSString *scheme;
> -    NSString *user;
> -    NSString *password;
> -    NSString *host;
> -    CFIndex port; // kCFNotFound means ignore/omit
> -    NSString *path;
> -    NSString *query;
> -    NSString *fragment;
> -} WebKitURLComponents;
> 

I presume this struct is no longer used -- you should mention that in the ChangeLog.

[Darin Adler]

http://trac.webkit.org/changeset/49273