Bug 301753
| Summary: | [run-jsc-stress-tests] Improve architecture checks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> |
| Component: | Tools / Tests | Assignee: | Angelos Oikonomopoulos <angelos> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | jenner, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 301959 | ||
| Bug Blocks: | |||
Angelos Oikonomopoulos
Check that the detected arch (if any) matches the specified arch (if any). Refuse to continue if no architecture has been specified and none was detected.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Angelos Oikonomopoulos
Pull request: https://github.com/WebKit/WebKit/pull/53255
EWS
Committed 302469@main (70adcaf42365): <https://commits.webkit.org/302469@main>
Reviewed commits have been landed. Closing PR #53255 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/163919154>
Robert Jenner
Reopened Bugzilla.
Broke JSC testing on macOS., tracking revert in https://bugs.webkit.org/show_bug.cgi?id=301959.
Robert Jenner
Apologies, but we had to revert: https://commits.webkit.org/302469@main at: https://commits.webkit.org/302559@main
It broke JSC testing for macOS observed here, and with the following error:
https://build.webkit.org/#/builders/1588/builds/735
Error: #<LoadError: cannot load such file -- highline>
Specified architecture (arm64) does not match that of the JSC binary (x86_64)
https://s3-us-west-2.amazonaws.com/archives.webkit.org/mac-sonoma-x86_64%20arm64-debug-jscore-test/302554@main-735.txt
We build the macOS builds with arm64 and x86_64 together. Please re-land your change that takes this into account.
Thank you!
Angelos Oikonomopoulos
Ah, thanks, will take another look!