Bug 301731
| Summary: | [GTK][WPE] Remove the WITH_OPENXR_RUNTIME environment variable | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <fujii> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | Keywords: | DoNotImportToRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Fujii Hironori
[GTK][WPE] Remove the WITH_OPENXR_RUNTIME environment variable
The test runner scripts run-gtk-tests and run-wpe-tests automatically set
the WITH_OPENXR_RUNTIME env var if the monado-service command was found.
And, TestWebKitWebXR ran the tests only if the WITH_OPENXR_RUNTIME env var was set.
If the SDK happens to not contain the monado-service command, the API tests are skipped.
No one will notice the problem.
Additionally, if the developers wanted to debug a bug of TestWebKitWebXR tests,
they had to set the WITH_OPENXR_RUNTIME env var before executing TestWebKitWebXR directly.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
Pull request: https://github.com/WebKit/WebKit/pull/53234
EWS
Committed 302385@main (742c0449ea78): <https://commits.webkit.org/302385@main>
Reviewed commits have been landed. Closing PR #53234 and removing active labels.