Bug 301708
| Summary: | REGRESSION: Some Feral games are crashing on launch | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=301592 | ||
Said Abou-Hallawa
The crash happens when applying CG filters on float16 unaccelerated backing store. Recently CG filters were in enabled for all CSS filters; see 300183@main and 300173@main. The problem is this scenario is not supported by the system frames right now.
302306@main tried fixed this issue by falling back to software filters in this case. This change addresses the case where an HDR image is styled with a CSS filters and is displayed on an unaccelerated backing store. This scenario can be hit with snapshotting like tab preview, print-preview, save to PDF and printing.
But it turned out that Feral games uses WK1 and they do not display HDR images. Instead AppKit creates float16 unaccelerated backing stories. So HDR images and their need to display on float16 backing stores is one of the cases that can hit this crash. The fix should be more generic than fixing the HDR images scenario.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Said Abou-Hallawa
rdar://163220052
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/53210
EWS
Committed 302365@main (8ad60ae162b2): <https://commits.webkit.org/302365@main>
Reviewed commits have been landed. Closing PR #53210 and removing active labels.