Bug 301639
| Summary: | [GLIB] Fix the WebKitWebsiteData/itp test | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Claudio Saavedra <csaavedra> |
| Component: | WebKitGTK | Assignee: | Claudio Saavedra <csaavedra> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, fujii |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Claudio Saavedra
.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Claudio Saavedra
Pull request: https://github.com/WebKit/WebKit/pull/53152
EWS
Committed 302302@main (70009e64105d): <https://commits.webkit.org/302302@main>
Reviewed commits have been landed. Closing PR #53152 and removing active labels.
Fujii Hironori
Unfortunately, still failing.
Unexpected failures (2)
/WebKitGTK/TestWebsiteData
/webkit/WebKitWebsiteData/itp
/webkit/WebKitWebsiteData/dom-cache
Buildbot: GTK-Linux-64-bit-Release-Tests: 302319@main
https://build.webkit.org/#/builders/57/builds/21923
Claudio Saavedra
Yes, there is an unrelated assertion than the one fixed in this patch. It's the same that makes other website data tests fail.
Claudio Saavedra
I think the problem is that under heavy load this is not enough waiting time:
// Give some time for the database to be updated.
test->wait(0.5);
GList* dataList = test->fetch(WEBKIT_WEBSITE_DATA_ITP);
g_assert_nonnull(dataList);
Would be nice if this could be deterministic instead of second-guessing how long we should wait.
In the other test that fails there is no wait() call.
Claudio Saavedra
https://bugs.webkit.org/show_bug.cgi?id=301689