Bug 301539
| Summary: | Selection reveal mode is not reset after reveal, and later results in an unwanted scrolling | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | arno renevier <a_renevier> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
arno renevier
In FrameSelection, m_selectionRevealMode flag is not reset after the selection is reveal. So, if a selection is revealed. And then some time later, the user focuses a different frame, a selection update will happen on the main frame (via a call to FrameSelection::updateCaretVisibility). Since reveal mode flag still has the initial value, the selection in the main frame will be revealed. It will cause unwanted scroll outside of the frame that the user has just focused.
See also rdar://163232293
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
arno renevier
<rdar://problem/163232293>
arno renevier
Pull request: https://github.com/WebKit/WebKit/pull/53061
EWS
Committed 302228@main (20e8b7686ab9): <https://commits.webkit.org/302228@main>
Reviewed commits have been landed. Closing PR #53061 and removing active labels.