Bug 301471
| Summary: | [WebKitGTK] apply-build-revision-to-files.py should support "Canonical-link" | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | WebKitGTK | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, webkit-bug-importer |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 266028 | ||
Sam Sneddon [:gsnedders]
As part of bug 266028, we need to migrate everything to supporting actual git trailers.
The best approach is probably replacing the existing code with something similar to:
```
git log --format=%B -1 HEAD | \
sed -e 's/Canonical link:/Canonical-link:/' | \
git -c trailer.Canonical-link.key=Canonical-link -c trailer.Identifier.key=Identifier -c trailer.git-svn-id.key=git-svn-id interpret-trailers --parse --no-divider
```
We need to specify the trailer.xxx.key config options because:
> Existing trailers are extracted from the input message by looking for a group of one or more lines that (i) is all trailers, or (ii) contains at least one Git-generated or user-configured trailer and consists of at least 25% trailers.
And we have plenty of groups which aren't all trailers in WebKit.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/64703
EWS
Committed 313429@main (f97ce6819bb9): <https://commits.webkit.org/313429@main>
Reviewed commits have been landed. Closing PR #64703 and removing active labels.