Bug 301458
| Summary: | Add a debug assertion for subclasses of CanMakeCheckedPtr to be always heap allocated | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | commit-queue, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=301519 | ||
| Bug Depends on: | 301488, 301522 | ||
| Bug Blocks: | |||
Ryosuke Niwa
For the purpose of guaranteeing safety, we must heap-allocate objects that are compatible with CheckedPtr/CheckedRef.
Add a debug assert that this condition holds.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/52985
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/53013
EWS
Committed 302184@main (e0db2dcca8c7): <https://commits.webkit.org/302184@main>
Reviewed commits have been landed. Closing PR #53013 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/163480143>
WebKit Commit Bot
Re-opened since this is blocked by bug 301522
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/53064
EWS
Committed 302223@main (b7a31900b46c): <https://commits.webkit.org/302223@main>
Reviewed commits have been landed. Closing PR #53064 and removing active labels.