Bug 301453
| Summary: | Fix TAPI verification errors on ARM64_32 builds. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | bmalloc | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
The fix entails:
1. Change pas_config.h's default setting of LIBPAS_ENABLED to 1 only apply when PAS_CPU(ADDRESS64). Otherwise default it to 0.
2. Add #if LIBPAS_ENABLED + #endif around the content of many libpas header files that TAPI complains about for ARM64_32 builds.
libpas does not support ARM64_32 targets. Hence, on ARM64_32 builds, libpas is disabled. So, it is correct to #if out all the libpas code in those header files.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/163372818>
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/52980
EWS
Committed 302174@main (501c1d5fe26d): <https://commits.webkit.org/302174@main>
Reviewed commits have been landed. Closing PR #52980 and removing active labels.