Bug 301444
| Summary: | suggestnominations.py should support Canonical-link | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 266028 | ||
Sam Sneddon [:gsnedders]
As part of bug 266028, we need to migrate everything to supporting actual git trailers.
We currently have:
```
Tools/Scripts/webkitpy/tool/commands/suggestnominations.py
56: _canonical_regexp = re.compile(r'^Canonical link: https://commits.webkit.org/(?P<canonicalid>\d+)@main$', re.MULTILINE)
```
Ideally we’d not only allow `Canonical-link`, but we’d move over to using `git-interpret-trailers` to actually find them — or just migrate the whole thing to webkitscmpy.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/163364894>