Bug 301422
| Summary: | [WPEPlatform] Silence unused variable warnings with USE_LIBDRM and USE_GBM disabled | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | WPE WebKit | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Adrian Perez
When libdrm and libgbm usage are disabled at build time (which is the case when targeting Android, for example), we get a number of warnings:
/home/aperez/devel/WebKit-Android/Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.cpp:70:11: warning: unused variable 'priv' [-Wunused-variable]
70 | auto* priv = WPE_DISPLAY_HEADLESS(object)->priv;
| ^~~~
/home/aperez/devel/WebKit-Android/Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.cpp:95:61: warning: unused parameter 'display' [-Wunused-parameter]
95 | static gpointer wpeDisplayHeadlessGetEGLDisplay(WPEDisplay* display, GError** error)
| ^
/home/aperez/devel/WebKit-Android/Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.cpp:197:61: warning: unused parameter 'name' [-Wunused-parameter]
197 | WPEDisplay* wpe_display_headless_new_for_device(const char* name, GError** error)
| ^
3 warnings generated.
Building CXX object Source/WebKit/WPEPlatform/CMakeFiles/WPEPlatform.dir/wpe/WPEDRMDevice.cpp.o
/home/aperez/devel/WebKit-Android/Source/WebKit/WPEPlatform/wpe/WPEDRMDevice.cpp:60:63: warning: unused parameter 'deviceFilename' [-Wunused-parameter]
60 | GRefPtr<WPEDRMDevice> wpeDRMDeviceCreateForDevice(const char* deviceFilename)
| ^
1 warning generated.
Building CXX object Source/WebKit/WPEPlatform/CMakeFiles/WPEPlatform.dir/wpe/WPEScreen.cpp.o
/home/aperez/devel/WebKit-Android/Source/WebKit/WPEPlatform/wpe/WPEScreen.cpp:154:44: warning: unused parameter 'screen' [-Wunused-parameter]
154 | static void wpeScreenInvalidate(WPEScreen* screen)
| ^
1 warning generated.
Building CXX object Source/WebKit/WPEPlatform/CMakeFiles/WPEPlatform.dir/wpe/WPEBufferDMABuf.cpp.o
/home/aperez/devel/WebKit-Android/Source/WebKit/WPEPlatform/wpe/WPEBufferDMABuf.cpp:86:11: warning: unused variable 'dmabufBuffer' [-Wunused-variable]
86 | auto* dmabufBuffer = WPE_BUFFER_DMA_BUF(object);
| ^~~~~~~~~~~~
1 warning generated.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/52951
EWS
Committed 302083@main (c22c1733b83c): <https://commits.webkit.org/302083@main>
Reviewed commits have been landed. Closing PR #52951 and removing active labels.