Bug 301390
| Summary: | Fix some issues with bmalloc header inclusions. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
1. In WTFConfig.cpp, we should only include bmalloc/pas_mte_config.h if BUSE(LIBPAS). This is condition for its inclusion elsewhere (see malloc's Gigacage.cpp and VMAllocate.cpp), but is neglected here.
2. VMAllocate.h should include BPlatform.h instead of BCompiler.h. BPlatform.h defines the BOS(), BCPU(), and BENABLE() macros that VMAllocate.h relies on below this. BCompiler.h does not. BPlatform.h also includes BCompiler.h. The only reason that this hasn't caused a problem so far is because VMAllocate.h also includes BAssert.h, which happens to include BPlatform.h. Regardless, we should fix this so that the includes truly reflect what is needed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/163306584>
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/52923
EWS
Committed 302094@main (f353ac71e5b8): <https://commits.webkit.org/302094@main>
Reviewed commits have been landed. Closing PR #52923 and removing active labels.