Summary: | Make InspectorTimelineAgent consistent with other components in Inspector. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kelly Norton <knorton> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | pfeldman, timothy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Kelly Norton
2009-10-06 12:46:01 PDT
Created attachment 41117 [details]
Removes TimelineAgent setting.
This removes the setting for the TimelineAgent since there is no immediate need for it and it's shaping up to look more like profiling than resource tracking.
Pavel - Should I add anything else to the patch to make it consistent with the other components in InspectorController?
Comment on attachment 41117 [details] Removes TimelineAgent setting. > -void InspectorBackend::enableTimeline(bool always) > +void InspectorBackend::enableTimeline() > { If you are implementing profiler-alike operation, you should consider naming these accordingly. In the profiler world start/stopProfiling are the methods controlling profiler. enable/disableProfiler methods are only making sure JS engine is ready for the operation as a whole. I think you should name yours start/stopTimelineProfiler or similar. Note that you won't find start/stopProfiling methods in the inspector controller API since they are not used anywhere other than Web Inspector frontend. That's why they only present in InspectorBackend interface. There are start/stopUserInitiatedProfiling methods that inspector controller exposes to the clients instead. It is up to you whether to expose start/stopTimelineProfiler methods in InspectorController API or limit their visibility to the frontend. Created attachment 41125 [details]
Updates the method names appropriately.
Note that you should be adding bug id into the ChangeLog. Unfortunately I noticed it only after landing. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorBackend.cpp M WebCore/inspector/InspectorBackend.h M WebCore/inspector/InspectorBackend.idl M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorController.h M WebCore/inspector/InspectorFrontend.cpp M WebCore/inspector/InspectorFrontend.h M WebCore/inspector/front-end/TimelineAgent.js Committed r49565 Comment on attachment 41125 [details]
Updates the method names appropriately.
Removing cq? from this closed bug.
|