Bug 301339
| Summary: | Web Inspector: REGRESSION(301917@main) Console messages are not rendered | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Razvan Caliman <rcaliman> |
| Component: | Web Inspector | Assignee: | Razvan Caliman <rcaliman> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 300728 | ||
| Bug Blocks: | |||
Razvan Caliman
Regressed by https://commits.webkit.org/301917@main
Changes in https://bugs.webkit.org/show_bug.cgi?id=300728 removed checks to ensure the message to be appended is an instance of `WI.ConsoleMessageView`. The message can also be a `WI.CommandView`
```
undefined is not an object (evaluating 'message.source') (at JavaScriptLogViewController.js:313:20)
_appendConsoleMessageView @ JavaScriptLogViewController.js:313:20
appendImmediateExecutionWithResult @ JavaScriptLogViewController.js:138:43
? @ DOMManager.js:623:79
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/163256970>
Razvan Caliman
Pull request: https://github.com/WebKit/WebKit/pull/52873
EWS
Committed 302032@main (ade3d3fcdde5): <https://commits.webkit.org/302032@main>
Reviewed commits have been landed. Closing PR #52873 and removing active labels.