Bug 30131

Summary: Make beforeload work with script elements
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: WebCore JavaScriptAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Dave Hyatt
Reported 2009-10-06 09:42:18 PDT
This patch makes the beforeload event fire on script elements.
Attachments
Patch (13.30 KB, patch)
2009-10-06 09:45 PDT, Dave Hyatt 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2009-10-06 09:45:41 PDT
Created attachment 40727 [details] Patch
Adam Roben (:aroben)
Comment 2 2009-10-06 10:02:53 PDT
Comment on attachment 40727 [details] Patch > +++ WebCore/dom/ScriptElement.h (working copy) > @@ -44,9 +44,10 @@ public: > virtual String languageAttributeValue() const = 0; > virtual String forAttributeValue() const = 0; > > + virtual bool dispatchBeforeLoadEvent(const String& sourceURL) = 0; > virtual void dispatchLoadEvent() = 0; > virtual void dispatchErrorEvent() = 0; > - > + Unneeded whitespace change here. I think you could share the dispatchBeforeLoadEvent implementation by making it a static protected helper function on ScriptElement. r=me
Dave Hyatt
Comment 3 2009-10-06 10:38:11 PDT
Fixed in r49194.
Note You need to log in before you can comment on or make changes to this bug.