Bug 301227
| Summary: | [MiniBrowser] Fix logging channel names being normalized as URLs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
After commits.webkit.org/301651@main, we treat string without a scheme as a URL, and normalize it with the proper scheme before passing it to MIniBrowser.
This caused issues with WebKit logging channels, which do not have schemes, and thus were being treated as URLs and getting schemes added.
Fix this by only normalizing if it actually looks like a URL (to not accidentally normalize a logging stream):
- starts with localhost
- looks like an IP address
- contains a dot (likely a domain) or slash (path)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/163146056>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/52770
EWS
Committed 301927@main (92b7489e014a): <https://commits.webkit.org/301927@main>
Reviewed commits have been landed. Closing PR #52770 and removing active labels.