Summary: | [GTK] Segfault while testing fast/events/keydown-keypress-preventDefault.html | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, mrobinson, xan.lopez | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Philippe Normand
2009-10-06 05:46:14 PDT
So basically it seems imContextCommitted can and will be called when there's an existing pendingComposition... Philippe, do you happen to know what GTK+ input method you are using? It's listed when you right click on an input field in GTK+. (In reply to comment #2) > Philippe, do you happen to know what GTK+ input method you are using? It's > listed when you right click on an input field in GTK+. This test is failing on our buildbot, I don't have access to the X server, we use XvFB Created attachment 40769 [details]
Fix for this issue
In this case it appears as though preventDefault() was preventing the creation of a keypress events. Preedit and completed composition data is processed during keypress events. Thus, in this test, the unused data was still lingering during the next keydown event. The attached patch handles this situation by first clearing the previous data, if any exists during keydown events.
Comment on attachment 40769 [details]
Fix for this issue
r=me
Comment on attachment 40769 [details] Fix for this issue Clearing flags on attachment: 40769 Committed r49233: <http://trac.webkit.org/changeset/49233> All reviewed patches have been landed. Closing bug. |