Bug 301150

Summary:	update-webkit-localizable-strings fails on multi-line strings in PluginDocument.cpp and FEComponentTransferCoreImageApplier.mm
Product:	WebKit	Reporter:	Timothy Hatcher <timothy>
Component:	Tools / Tests	Assignee:	Alexey Proskuryakov <ap>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Timothy Hatcher

Reported 2025-10-20 17:04:12 PDT

The R"" multi-line strings in PluginDocument.cpp and FEComponentTransferCoreImageApplier.mm are preventing the script from updating Localizable.strings. > update-webkit-localizable-strings Source/WebCore/html/PluginDocument.cpp:85: mismatched quotes Source/WebCore/html/PluginDocument.cpp:89: mismatched quotes Source/WebCore/platform/LocalizedStrings.cpp:623: warning: encountered the same key, "Default", twice, with different comments Source/WebCore/platform/LocalizedStrings.cpp:380: warning: previous occurrence Source/WebCore/platform/LocalizedStrings.cpp:853: warning: encountered the same key, "section footer", twice, with different comments Source/WebCore/platform/LocalizedStrings.cpp:689: warning: previous occurrence Source/WebCore/platform/LocalizedStrings.cpp:855: warning: encountered the same key, "section header", twice, with different comments Source/WebCore/platform/LocalizedStrings.cpp:694: warning: previous occurrence Source/WebCore/platform/graphics/coreimage/FEComponentTransferCoreImageApplier.mm:75: mismatched quotes Source/WebCore/platform/graphics/coreimage/FEComponentTransferCoreImageApplier.mm:89: mismatched quotes Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9839: warning: encountered the same key, "Enter a number", twice, with different comments Source/WebCore/platform/LocalizedStrings.cpp:1332: warning: previous occurrence Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9841: warning: encountered the same key, "Search", twice, with different comments Source/WebCore/platform/LocalizedStrings.cpp:1531: warning: previous occurrence Source/WebKitLegacy/mac/WebView/WebPDFView.mm:398: warning: encountered the same key, "Open with %@", twice, with different comments Source/WebCore/platform/LocalizedStrings.cpp:535: warning: previous occurrence 776 localizable strings 6 key collisions 63820 strings not marked for localization Errors encountered. Exiting without writing to Source/WebCore/en.lproj/Localizable.strings.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2025-10-20 17:52:58 PDT

<rdar://problem/163078071>

Alexey Proskuryakov

Comment 2 2025-10-20 17:56:24 PDT

Pull request: https://github.com/WebKit/WebKit/pull/52703

EWS

Comment 3 2025-10-20 21:39:27 PDT

Committed 301849@main (a93bfba26810): <https://commits.webkit.org/301849@main> Reviewed commits have been landed. Closing PR #52703 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.