Bug 301099 – REGRESSION(301755@main): Broke the Tahoe build

• Component: New Bugs
• Status: REOPENED

[Jonathan Bedard]

In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:6:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ObscuredContentInsets.mm:346:34: error: instance method '-prefersSolidColorHardPocket' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
  346 |     EXPECT_TRUE([topScrollPocket prefersSolidColorHardPocket]); // Solid color is preferred when the page is not scrolled.
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:1:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/TestWebKitAPIPrefix.h:51:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest.h:1807:50: note: expanded from macro 'EXPECT_TRUE'
 1807 | #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest.h:1792:23: note: expanded from macro 'GTEST_EXPECT_TRUE'
 1792 |   GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:1:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/TestWebKitAPIPrefix.h:51:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest.h:65:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest-death-test.h:43:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/internal/gtest-death-test-internal.h:47:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest-matchers.h:49:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest-printers.h:122:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/internal/gtest-internal.h:1493:38: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
 1493 |           ::testing::AssertionResult(expression))                     \
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:6:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ObscuredContentInsets.mm:30:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:112:12: note: receiver is instance of class declared here
  112 | @interface NSScrollPocket : NSView
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:6:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ObscuredContentInsets.mm:350:34: error: instance method '-prefersSolidColorHardPocket' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
  350 |         return ![topScrollPocket prefersSolidColorHardPocket];
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:6:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ObscuredContentInsets.mm:30:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:112:12: note: receiver is instance of class declared here
  112 | @interface NSScrollPocket : NSView
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:6:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ObscuredContentInsets.mm:354:34: error: instance method '-prefersSolidColorHardPocket' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
  354 |     EXPECT_TRUE([topScrollPocket prefersSolidColorHardPocket]);
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:1:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/TestWebKitAPIPrefix.h:51:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest.h:1807:50: note: expanded from macro 'EXPECT_TRUE'
 1807 | #define EXPECT_TRUE(condition) GTEST_EXPECT_TRUE(condition)
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest.h:1792:23: note: expanded from macro 'GTEST_EXPECT_TRUE'
 1792 |   GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:1:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/TestWebKitAPIPrefix.h:51:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest.h:65:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest-death-test.h:43:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/internal/gtest-death-test-internal.h:47:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest-matchers.h:49:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest-printers.h:122:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/internal/gtest-internal.h:1493:38: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
 1493 |           ::testing::AssertionResult(expression))                     \
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:6:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ObscuredContentInsets.mm:30:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:112:12: note: receiver is instance of class declared here
  112 | @interface NSScrollPocket : NSView
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:6:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ObscuredContentInsets.mm:357:35: error: instance method '-prefersSolidColorHardPocket' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
  357 |     EXPECT_FALSE([topScrollPocket prefersSolidColorHardPocket]);
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:1:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/TestWebKitAPIPrefix.h:51:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest.h:1811:52: note: expanded from macro 'EXPECT_FALSE'
 1811 | #define EXPECT_FALSE(condition) GTEST_EXPECT_FALSE(condition)
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest.h:1795:25: note: expanded from macro 'GTEST_EXPECT_FALSE'
 1795 |   GTEST_TEST_BOOLEAN_(!(condition), #condition, true, false, \
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:1:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/TestWebKitAPIPrefix.h:51:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest.h:65:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest-death-test.h:43:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/internal/gtest-death-test-internal.h:47:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest-matchers.h:49:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/gtest-printers.h:122:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/usr/local/include/gtest/internal/gtest-internal.h:1493:38: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
 1493 |           ::testing::AssertionResult(expression))                     \
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/WebKitBuild/Debug/DerivedSources/TestWebKitAPI/unified-sources/UnifiedSource20-nonARC.mm:6:
In file included from /Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ObscuredContentInsets.mm:30:
/Volumes/Data/worker/Apple-Tahoe-Debug-Build/build/Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:112:12: note: receiver is instance of class declared here
  112 | @interface NSScrollPocket : NSView
4 errors generated.

[Radar WebKit Bug Importer]

<rdar://problem/163041630>

[Wenson Hsieh]

Pull request: https://github.com/WebKit/WebKit/pull/52659

[Jonathan Bedard]

Looks like https://bugs.webkit.org/show_bug.cgi?id=301069 is the same issue

[Jonathan Bedard]

*** Bug 301069 has been marked as a duplicate of this bug. ***

[EWS]

Committed 301812@main (d0865d96da98): <https://commits.webkit.org/301812@main>

Reviewed commits have been landed. Closing PR #52659 and removing active labels.

[David Kilzer (:ddkilzer)]

Re-opening for pull request https://github.com/apple/WebKit/pull/4127

[David Kilzer (:ddkilzer)]

<rdar://problem/166944524>