Bug 301095
| Summary: | Implement IPC error string reporting in testing for IPC::Connection | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jon Butler <jonbutler> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jon Butler
This patch implements the first part of the IPC error string reporting feature, covering both IDL validation and MESSAGE_CHECK failures for IPC::Connection. It introduces:
- Error string tracking in the Decoder, and changes to the code generation to set this error string on validation failure
- Error string tracking on the Connection, and changes to the MESSAGE_CHECK logic to set the error string on failure
- An IPC Testing API method to check for an error string on a specific connection, and a layout test showing its usage and testing the implementation of this feature by calling a test message, IPCTester.CheckTestParameter
A few design decisions:
- Error messages are checked for directly by WebContent rather than sent back as an out-of-band message from the receiver. This allows WebContent to know when it can continue if there wasn't an error, rather than waiting for a message that may not be coming.
- The feature is 100% behind the IPC_TESTING_API feature flag, and only enabled in testing configurations
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/163035367>
Jon Butler
Pull request: https://github.com/WebKit/WebKit/pull/52656
EWS
Committed 302528@main (2837e1eaeb3d): <https://commits.webkit.org/302528@main>
Reviewed commits have been landed. Closing PR #52656 and removing active labels.