Bug 301083
| Summary: | ☂️ [META][CMake] Finish migrating find-modules to use imported targets | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | CMake | Assignee: | WebKitGTK+ bugs <bugs-noreply> |
| Status: | NEW | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 302580, 302581, 302824, 302846, 302860 | ||
| Bug Blocks: | |||
Adrian Perez
We have been slowly improving the find-modules (Source/cmake/Find*.cmake) to use imported targets. It should be possible to give the task a final push and have the pending modules updated as well. As of 2025/10/20 the pending ones are:
- Source/cmake/FindATK.cmake
- Source/cmake/FindATSPI.cmake
- Source/cmake/FindEGL.cmake *
- Source/cmake/FindEnchant.cmake
- Source/cmake/FindFlite.cmake ***
- Source/cmake/FindGStreamer.cmake ***
- Source/cmake/FindHyphen.cmake
- Source/cmake/FindLibsecret.cmake
- Source/cmake/FindLibtasn1.cmake
- Source/cmake/FindLibxkbcommon.cmake
- Source/cmake/FindThunder.cmake *
- Source/cmake/FindWayland.cmake **
The asterisks above mean:
*) Might be tricky to test that it works in all possible build configurations, and/or in embedded devices.
**) Medium complexity, the updated module would have have an imported target for each component.
***) Complex, on top of needed targets for each component, it has many components to handle.
So at least the unmarked ones should be low-hanging fruit.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |