Bug 300968
| Summary: | SwiftBrowser errantly builds with iOS SDK on watchOS and tvOS. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Schwartz <ben_schwartz> |
| Component: | Tools / Tests | Assignee: | Ben Schwartz <ben_schwartz> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | a_protyasha, emw, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ben Schwartz
When building for watchOS and tvOS, since these platforms aren't marked as supported platforms, SwiftBrowser is built with the iOS SDK targeting those platforms. To prevent this, we need to add "watchos watchsimulator appletvos appletvsimulator" to SUPPORTED_PLATFORMS in `SwiftBrowser/Configurations/Base.xcconfig`. Builds of SwiftBrowser will then be prevented below, as WK_ENABLE_SWIFTBROWSER will be NO for those SDKs.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/162843312>
Ben Schwartz
Pull request: https://github.com/WebKit/WebKit/pull/52546
EWS
Committed 301715@main (d05c8605fcf4): <https://commits.webkit.org/301715@main>
Reviewed commits have been landed. Closing PR #52546 and removing active labels.