Bug 300850
| Summary: | Fix -Wmissing-declarations warnings during JavaScriptCore module verification | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | JavaScriptCore | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Kilzer (:ddkilzer)
Fix -Wmissing-declarations warnings during JavaScriptCore module verification.
This happens because TrackedReferences.h is marked as a private header for JavaScriptCore.framework, but it doesn't export any methods.
```
In file included from WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/VerifyModule/JavaScriptCore/objective-c++/Test.mm:1:
In file included from WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/VerifyModule/JavaScriptCore/objective-c++/Test.framework/Headers/Test.h:792:
WebKitBuild/Release/JavaScriptCore.framework/PrivateHeaders/TrackedReferences.h:43:5: warning: declaration does not declare anything [-Wmissing-declarations]
43 | void check(JSCell*) const;
| ^~~~~~~~~~~~~~~~~~~~~~~~~
WebKitBuild/Release/JavaScriptCore.framework/PrivateHeaders/TrackedReferences.h:44:5: warning: declaration does not declare anything [-Wmissing-declarations]
44 | void check(JSValue) const;
| ^~~~~~~~~~~~~~~~~~~~~~~~~
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/162735197>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/52436
EWS
Committed 301645@main (8e39b0b531eb): <https://commits.webkit.org/301645@main>
Reviewed commits have been landed. Closing PR #52436 and removing active labels.