Bug 30084

Summary: webkit-patch commit-queue does not notice modifications to committers.py
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: jparent, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 30634, 32911    
Bug Blocks:    
Attachments:
Description Flags
Add re-exec support
none
Add re-exec support none

Eric Seidel (no email)
Reported 2009-10-05 11:17:00 PDT
bugzilla-tool commit-queue does not notice modifications to committers.py I'm not sure if it notices them after an update-webkit call or not. I think it might be requiring a restart. Either way, we should make it so that no restart, or patch landing is required. Once someone adds themselves to committers.py, setting commit-queue+ should "just work" for them.
Attachments
Add re-exec support (9.27 KB, patch)
2009-10-21 11:22 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Add re-exec support (9.26 KB, patch)
2009-10-21 11:40 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-10-21 11:22:55 PDT
Created attachment 41587 [details] Add re-exec support
Eric Seidel (no email)
Comment 2 2009-10-21 11:40:55 PDT
Created attachment 41595 [details] Add re-exec support
Eric Seidel (no email)
Comment 3 2009-10-21 11:49:00 PDT
Comment on attachment 41595 [details] Add re-exec support Removing cq? until bug 30634 is landed.
Adam Barth
Comment 4 2009-10-22 00:01:55 PDT
Comment on attachment 41595 [details] Add re-exec support You're blowing my mind with your crazy continuation style here.
Eric Seidel (no email)
Comment 5 2009-10-26 15:34:26 PDT
Committed r50105: <http://trac.webkit.org/changeset/50105>
Eric Seidel (no email)
Comment 6 2009-10-30 15:41:35 PDT
Rolled out in: Committed r50362: <http://trac.webkit.org/changeset/50362> This was causing https://bugs.webkit.org/show_bug.cgi?id=30869
Eric Seidel (no email)
Comment 7 2009-10-30 15:43:24 PDT
*** Bug 30869 has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
Comment 8 2009-11-02 18:15:00 PST
I think the best plan for now is to add some explicit code to reload just the committers.py module on every run.
Eric Seidel (no email)
Comment 9 2009-12-23 15:51:46 PST
Using bug 32911 for a workaround for now.
Eric Seidel (no email)
Comment 10 2010-05-10 15:40:27 PDT
This has been solved by making the commit-queue automatically restart itself every 10 cycles using a wrapper script.
Note You need to log in before you can comment on or make changes to this bug.