webkit-patch commit-queue does not notice modifications to committers.py

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

bugzilla-tool commit-queue does not notice modifications to committers.py

I'm not sure if it notices them after an update-webkit call or not.  I think it might be requiring a restart.  Either way, we should make it so that no restart, or patch landing is required.  Once someone adds themselves to committers.py, setting commit-queue+ should "just work" for them.

[Eric Seidel (no email)]

Created attachment 41587 [details]
Add re-exec support

[Eric Seidel (no email)]

Created attachment 41595 [details]
Add re-exec support

[Eric Seidel (no email)]

Comment on attachment 41595 [details]
Add re-exec support

Removing cq? until bug 30634 is landed.

[Adam Barth]

Comment on attachment 41595 [details]
Add re-exec support

You're blowing my mind with your crazy continuation style here.

[Eric Seidel (no email)]

Committed r50105: <http://trac.webkit.org/changeset/50105>

[Eric Seidel (no email)]

Rolled out in:
Committed r50362: <http://trac.webkit.org/changeset/50362>

This was causing https://bugs.webkit.org/show_bug.cgi?id=30869

[Eric Seidel (no email)]

*** Bug 30869 has been marked as a duplicate of this bug. ***

[Eric Seidel (no email)]

I think the best plan for now is to add some explicit code to reload just the committers.py module on every run.

[Eric Seidel (no email)]

Using bug 32911 for a workaround for now.

[Eric Seidel (no email)]

This has been solved by making the commit-queue automatically restart itself every 10 cycles using a wrapper script.