Bug 300740
| Summary: | [Web Inspector] _consoleMessageViews are not cleared when new session is started. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <basuke> |
| Component: | New Bugs | Assignee: | Basuke Suzuki <basuke> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Basuke Suzuki
LogContentView does keep all messageView for each console messages in _consoleMessageViews. It keeps the obsolete views after new session is started. This is memory leak.
Steps To Reproduce:
1. Open Web Inspector. Log something using console.log.
2. Reload the page. Console log view should has been cleared.
3. Open Web Inspector for Web Inspector. (https://a1391192.slack.com/archives/GMD6ADPLM/p1758231029864959?thread_ts=1758230885.563809&cid=GMD6ADPLM)
4. Type `WI.consoleContentView._logViewController._consoleMessageViews` in the console message.
Results:
You will see many entries with non attached messageViews.
Regression:
It should be cleared when new session is created.
This bug was introduced at 258675@main.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Basuke Suzuki
rdar://162638323
Basuke Suzuki
Pull request: https://github.com/WebKit/WebKit/pull/52404
EWS
Committed 301638@main (748645e2c4d3): <https://commits.webkit.org/301638@main>
Reviewed commits have been landed. Closing PR #52404 and removing active labels.