Bug 300732
| Summary: | [WebGPU Swift] 1 crash and 3 text failures with Swift backend | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Wyrzykowski <mwyrzykowski> |
| Component: | WebGPU | Assignee: | Geoffrey Garen <ggaren> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ggaren, mwyrzykowski, tzagallo, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mike Wyrzykowski
With the latest Swift compiler, running:
./Tools/Scripts/run-webkit-tests --release --no-build http/tests/webgpu/webgpu
results in:
[1/4] http/tests/webgpu/webgpu/api/operation/adapter/requestDevice.html failed unexpectedly (com.apple.WebKit.GPU.Development crashed [pid=81974])
[2/4] http/tests/webgpu/webgpu/api/validation/encoding/cmds/render/dynamic_state.html failed unexpectedly (text diff)
[3/4] http/tests/webgpu/webgpu/api/validation/encoding/queries/resolveQuerySet.html failed unexpectedly (text diff)
[4/4] http/tests/webgpu/webgpu/api/validation/queue/destroyed/query_set.html failed unexpectedly (text diff)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Geoffrey Garen
Thread 10 name: WebGPU work queue Crashed:: :
0 com.apple.WebGPU 0x102a7c3c0 WebGPU.CommandEncoder.beginRenderPass(descriptor:)
1 com.apple.WebGPU 0x102a78d3c CommandEncoder_beginRenderPass_thunk(commandEncoder:descriptor:)
2 com.apple.WebGPU 0x102a00db4 WebGPU::CommandEncoder::beginRenderPass(WGPURenderPassDescriptor const&)
3 com.apple.WebGPU 0x102a0aa28 wgpuCommandEncoderBeginRenderPass(WGPUCommandEncoderImpl*, WGPURenderPassDescriptor const*)
4 com.apple.WebCore 0x115ef1bfc WebCore::WebGPU::CommandEncoderImpl::beginRenderPass(WebCore::WebGPU::RenderPassDescriptor const&)
...
Geoffrey Garen
Exception Type: EXC_BREAKPOINT (SIGTRAP)
Geoffrey Garen
Seems like this must a Swift precondition failure of some sort.
Mike Wyrzykowski
missing nil check is the reason for the crash
Radar WebKit Bug Importer
<rdar://problem/162639798>
Geoffrey Garen
Pull request: https://github.com/WebKit/WebKit/pull/52363
EWS
Committed 301553@main (71e9079abf4a): <https://commits.webkit.org/301553@main>
Reviewed commits have been landed. Closing PR #52363 and removing active labels.