Bug 300685
| Summary: | [GTK] Create the platform cursor when set on the web view | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | WebKitGTK | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, dpino |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Garcia Campos
Similar to what WPE does. This way we don't need to handle platform cursor in WebCore::Cursor
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/52287
EWS
Committed 301467@main (86a8ee99fda7): <https://commits.webkit.org/301467@main>
Reviewed commits have been landed. Closing PR #52287 and removing active labels.
Diego Pino
This patch broke the GTK3 build:
https://build.webkit.org/#/builders/1519/builds/7786
```
/home/buildbot-worker/GTK-Linux-64-bit-Release-GTK3-Build/build/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: In function ‘void webkitWebViewBaseSetCursor(WebKitWebViewBase*, const WebCore::Cursor&)’:
/home/buildbot-worker/GTK-Linux-64-bit-Release-GTK3-Build/build/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:3684:47: error: ‘gdk_cursor_get_name’ was not declared in this scope; did you mean ‘gdk_cursor_get_type’?
3684 | if (currentCursor && !g_strcmp0(name, gdk_cursor_get_name(currentCursor)))
| ^~~~~~~~~~~~~~~~~~~
| gdk_cursor_get_type
/home/buildbot-worker/GTK-Linux-64-bit-Release-GTK3-Build/build/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:3719:19: error: ‘skiaImageToGdkTexture’ was not declared in this scope
3719 | auto pixbuf = skiaImageToGdkTexture(*platformImage.get());
| ^~~~~~~~~~~~~~~~~~~~~
```
Diego Pino
Re-opening for pull request https://github.com/WebKit/WebKit/pull/52378
EWS
Committed 301550@main (3f2781927763): <https://commits.webkit.org/301550@main>
Reviewed commits have been landed. Closing PR #52378 and removing active labels.