Bug 300589

Summary:	[Style] Cleanup CSSCalcValue
Product:	WebKit	Reporter:	Sam Weinig <sam>
Component:	CSS	Assignee:	Sam Weinig <sam>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	koivisto, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari 18
Hardware:	Unspecified
OS:	Unspecified

Sam Weinig

Reported 2025-10-12 11:36:00 PDT

- Rename to CSSCalc::Value for consistency with the rest of CSS calc() code. - Remove inheritance from CSSValue. It serves no purpose, you never have use it polymorphically.

Attachments
Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2025-10-12 11:41:14 PDT

Pull request: https://github.com/WebKit/WebKit/pull/52184

Sam Weinig

Comment 2 2025-10-12 11:43:19 PDT

Pull request: https://github.com/WebKit/WebKit/pull/52203

EWS

Comment 3 2025-10-14 13:51:10 PDT

Committed 301495@main (b97486202ae2): <https://commits.webkit.org/301495@main> Reviewed commits have been landed. Closing PR #52203 and removing active labels.

Radar WebKit Bug Importer

Comment 4 2025-10-14 13:52:12 PDT

<rdar://problem/162628937>

Note You need to log in before you can comment on or make changes to this bug.