Bug 300535
| Summary: | [WPE] WPE Platform: Unset WPE_DRM_DEVICE for Tests using WPEMockPlatformTest | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | WPE WebKit | Assignee: | Lauro Moura <lmoura> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Lauro Moura
If we set WPE_DRM_DEVICE, the test Display/drm-nodes fails, as `wpe_display_get_drm_device` first checks for this variable before asking for the actual platform implementation (see bug300527)
ERROR:/home/lauro/wkdev-shared/dev/wk-gtk/WebKit-GTK/Tools/TestWebKitAPI/Tests/WPEPlatform/TestDisplay.cpp:80:void TestWebKitAPI::testDisplayDRMNodes(WPEMockPlatformTest*, gconstpointer): 'wpe_display_get_drm_device(test->display())'
should be nullptr
Ideally, as this is a mocked platform, we should not let WPE_DRM_DEVICE get in the way.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/52160
EWS
Committed 301390@main (6339f3f43057): <https://commits.webkit.org/301390@main>
Reviewed commits have been landed. Closing PR #52160 and removing active labels.