Bug 300502
| Summary: | Fix UnretainedCallArgs errors in GeneratedWebKitSecureCoding.mm | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Frédéric Wang Nélar <fred.wang> |
| Component: | New Bugs | Assignee: | Frédéric Wang Nélar <fred.wang> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Frédéric Wang Nélar
There are several calls to isKindOfClass that seem to receive an unretained argument, for example:
https://build.webkit.org/results/Apple-Sequoia-Safer-CPP-Checks/301307@main%20(5567)/scan-build-output/StaticAnalyzer/WebKit/StaticAnalyzerReports/report-GeneratedWebKitSecureCoding.mm-CoreIPCAVOutputContext-3-6f5ea8.html#EndPath
I guess most of them will be fixed by tweaking the relevant places in the python generator script:
https://searchfox.org/wubkat/search?q=isKindOfClass%3A&path=generate-serializers.py&case=true®exp=false
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Frédéric Wang Nélar
(In reply to Frédéric Wang (:fredw) from comment #0)
> https://searchfox.org/wubkat/search?q=isKindOfClass%3A&path=generate-
> serializers.py&case=true®exp=false
https://searchfox.org/wubkat/rev/dd05eb230972a07f0240b959e6e22ca685ef3445/Source/WebKit/Scripts/generate-serializers.py#395 even
Frédéric Wang Nélar
Pull request: https://github.com/WebKit/WebKit/pull/52116
EWS
Committed 301353@main (08f7cb918061): <https://commits.webkit.org/301353@main>
Reviewed commits have been landed. Closing PR #52116 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/162426063>