Bug 300490

Summary:	[JSC] Remove unused default parameters from `JSInternalPromise::then`
Product:	WebKit	Reporter:	Sosuke Suzuki <sosuke>
Component:	JavaScriptCore	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Sosuke Suzuki

Reported 2025-10-09 22:49:54 PDT

This patch removes unused default parameters from `JSInternalPromise::then`. This patch also adds `ASSERT` statements to check that `onFulfilled` and `onRejected` are not `nullptr`. If these parameters are `nullptr`, a segmentation fault will occur in `performPromiseThen`.

Attachments
Add attachment proposed patch, testcase, etc.

Sosuke Suzuki

Comment 1 2025-10-09 22:54:42 PDT

Pull request: https://github.com/WebKit/WebKit/pull/52104

EWS

Comment 2 2025-10-11 06:53:22 PDT

Committed 301356@main (50aa3e6d5536): <https://commits.webkit.org/301356@main> Reviewed commits have been landed. Closing PR #52104 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2025-10-11 06:54:13 PDT

<rdar://problem/162432838>

Note You need to log in before you can comment on or make changes to this bug.