Bug 300401
| Summary: | [ews-build] Update unit-tests for buildbot 4 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | New Bugs | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=299036 | ||
Aakash Jain
[ews-build] Update unit-tests for buildbot 4
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/162221529>
Sam Sneddon [:gsnedders]
To copy/paste my comment from bug 299036:
(Forwarded from Sam Sneddon [:gsnedders] from comment #4)
> There's a draft PR up on https://github.com/WebKit/WebKit/pull/52518 which
> while mostly just done with `sed` substantially moves us towards things
> passing — this also covers bug 300401, because there was no reason to limit
> sed to one directory at a time.
>
> I think there's some more low-hanging fruit with properties that will fix a
> bit, logging output being required to end with new lines… but it's
> definitely the majority of the changes needed.
Aakash Jain
Pull request: https://github.com/WebKit/WebKit/pull/53745
Sam Sneddon [:gsnedders]
git-webkit didn't link the new PR: https://github.com/WebKit/WebKit/pull/52518
EWS
Committed 302931@main (ac5d56c79ec9): <https://commits.webkit.org/302931@main>
Reviewed commits have been landed. Closing PR #52518 and removing active labels.